Skip to content

feat: force ws enabled via mdm (WPB-23228) #4583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sbakhtiarov wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

feat: force ws enabled via mdm (WPB-23228) #4583

sbakhtiarov wants to merge 9 commits into from

Conversation

@sbakhtiarov
Copy link
Contributor

@sbakhtiarov sbakhtiarov commented Feb 9, 2026 •
edited by github-actions bot
Loading

https://wearezeta.atlassian.net/browse/WPB-23228

https://wearezeta.atlassian.net/browse/WPB-23228

What's new in this PR?

New key KEEP_WEBSOCKET_CONNECTION in MDM config allows admin to enforce background socket connection for all users. This PR implements support for this feature.

  • New KEEP_WEBSOCKET_CONNECTION MDM key
  • DataStore used for storing the new key value
  • Updated logic for starting persistent websocket service.
  • Disable "Keep network connection" option in network settings if enforced by MDM.

@sbakhtiarov sbakhtiarov changed the title Mo/force ws enabled via mdm feat: force ws enabled via mdm (WPB-23228) Feb 10, 2026
@sbakhtiarov sbakhtiarov marked this pull request as ready for review February 10, 2026 08:11
@codecov
Copy link

codecov bot commented Feb 10, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 67.64706% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.72%. Comparing base (1d918e7) to head (47c1ee1).

Files with missing lines Patch % Lines
...ttings/networkSettings/NetworkSettingsViewModel.kt 0.00% 12 Missing ⚠️
...otlin/com/wire/android/ui/WireActivityViewModel.kt 64.28% 5 Missing ⚠️
...ppsettings/networkSettings/NetworkSettingsState.kt 0.00% 2 Missing ⚠️
...in/kotlin/com/wire/android/util/WebsocketHelper.kt 50.00% 1 Missing and 1 partial ⚠️
...m/wire/android/emm/ManagedConfigurationsManager.kt 93.33% 0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (67.64%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #4583      +/-   ##
===========================================
+ Coverage    48.66%   48.72%   +0.06%     
===========================================
  Files          576      576              
  Lines        19952    20008      +56     
  Branches      3337     3347      +10     
===========================================
+ Hits          9709     9749      +40     
- Misses        9216     9230      +14     
- Partials      1027     1029       +2
Files with missing lines Coverage Δ
...tlin/com/wire/android/datastore/GlobalDataStore.kt 26.66% <100.00%> (+7.36%) ⬆️
.../com/wire/android/emm/ManagedConfigurationsKeys.kt 100.00% <100.00%> (ø)
.../wire/android/emm/ManagedConfigurationsReceiver.kt 76.47% <100.00%> (+7.23%) ⬆️
...re/ShouldStartPersistentWebSocketServiceUseCase.kt 100.00% <100.00%> (ø)
...rc/main/kotlin/com/wire/android/ui/WireActivity.kt 0.00% <ø> (ø)
...m/wire/android/emm/ManagedConfigurationsManager.kt 89.01% <93.33%> (+0.85%) ⬆️
...ppsettings/networkSettings/NetworkSettingsState.kt 0.00% <0.00%> (ø)
...in/kotlin/com/wire/android/util/WebsocketHelper.kt 50.00% <50.00%> (+50.00%) ⬆️
...otlin/com/wire/android/ui/WireActivityViewModel.kt 74.02% <64.28%> (-0.98%) ⬇️
...ttings/networkSettings/NetworkSettingsViewModel.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d918e7...47c1ee1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 10, 2026

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MohamadJaara MohamadJaara MohamadJaara approved these changes

@saleniuk saleniuk saleniuk approved these changes

Assignees

@sbakhtiarov sbakhtiarov

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sbakhtiarov @MohamadJaara @saleniuk